Review Request 124258: Added an interface to append child pages to the "Language support" config page

[Sergey Kalinichev]

> On July 12, 2015, 11:51 p.m., Milian Wolff wrote:
> > interfaces/configpage.h, line 73
> > <https://git.reviewboard.kde.org/r/124258/diff/2/?file=384413#file384413line73>
> >
> >     What happens when a LanguageConfigPage has childPages itself? That is not supported now, is it? And thereby, it shows that this API design does not work so nicely, no?
> 
> Alex Richardson wrote:
>     It should work since ConfigDialog recursively adds all the child pages. Not 100% sure as it's been a while since I looked at that code.

Yes it used to work, but I accidentally broke it. Should be fixed now.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124258/#review82421
-----------------------------------------------------------


On July 12, 2015, 1:20 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124258/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 1:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Now a config page that contains language specific settings can be appended as a child page to the "Language support" config page.
> 
> This is useful for e.g. kdev-clang plugin. See also https://git.reviewboard.kde.org/r/124139/
> 
> 
> Diffs
> -----
> 
>   interfaces/configpage.h aed5dd6 
>   interfaces/configpage.cpp 939c9d9 
>   shell/CMakeLists.txt cffa161 
>   shell/configdialog.h 2bf7f77 
>   shell/configdialog.cpp 1e2eaab 
>   shell/languagecontroller.cpp d15a14b 
>   shell/settings/ccconfig.kcfg  
>   shell/settings/ccconfig.kcfgc 8fd94ca 
>   shell/settings/ccpreferences.h a736c36 
>   shell/settings/ccpreferences.cpp 9346e23 
>   shell/settings/ccpreferences.ui 48bd90f 
>   shell/settings/languageconfig.kcfgc PRE-CREATION 
>   shell/uicontroller.cpp 6a662ce 
> 
> Diff: https://git.reviewboard.kde.org/r/124258/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> LanguageSupport.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/05/ab17b5f1-b8c2-4383-8b0e-799f44dde14b__LanguageSupport.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150714/3b1018f4/attachment-0001.html>