Review Request 124300: Change signature

[Maciej Poleski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124300/
-----------------------------------------------------------

(Updated Lip 13, 2015, 11:34 po południu)


Review request for KDevelop.


Changes
-------

Finished implementation.

It was terrible experience...


Repository: kdev-clang


Description (updated)
-------

Change signature refactoring

I decided not to implement rename function refactoring. Change signature will provide this functionality.
We can rename all functions except constructors, destructors, conversion operators, operators.
Operators must preserve number of parameters (imagine 2+2 and operator+).

This functionality allows to:
- change return type
- change function name
- change parameter types (preserving identity, tracking of this is not perfect - we lose this information)
- change order of parameters
- introduce new parameters
- remove existing parameters

Somewhere here should be screenshoot of this dialog...


Diffs (updated)
-----

  refactoring/CMakeLists.txt PRE-CREATION 
  refactoring/changesignaturedialog.h PRE-CREATION 
  refactoring/changesignaturedialog.cpp PRE-CREATION 
  refactoring/changesignaturedialog.ui PRE-CREATION 
  refactoring/changesignaturerefactoring.h PRE-CREATION 
  refactoring/changesignaturerefactoring.cpp PRE-CREATION 
  refactoring/changesignaturerefactoringchangepack.h PRE-CREATION 
  refactoring/changesignaturerefactoringchangepack.cpp PRE-CREATION 
  refactoring/changesignaturerefactoringinfopack.h PRE-CREATION 
  refactoring/changesignaturerefactoringinfopack.cpp PRE-CREATION 
  refactoring/debug.h PRE-CREATION 
  refactoring/refactoring.h PRE-CREATION 
  refactoring/refactoring.cpp PRE-CREATION 
  refactoring/refactoringmanager.cpp PRE-CREATION 
  refactoring/utils.h PRE-CREATION 
  refactoring/utils.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/124300/diff/


Testing (updated)
-------

Manual testing of GUI. No transformation tests yet...


File Attachments
----------------

snapshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/08/e8a8db09-92f9-4fb6-ac4a-3ab2a5051033__snapshot1.png


Thanks,

Maciej Poleski

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150713/9b1ef759/attachment.html>