Review Request 124334: WIP: port away from QtQuick1

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124334/#review82450
-----------------------------------------------------------


Thanks!


shell/assistantpopup.cpp (line 266)
<https://git.reviewboard.kde.org/r/124334/#comment56842>

    Hopefully not, since this was a workaround for QGraphicsView behaviour, which is not involved any more. It probably can just be removed.


- Sven Brauch


On July 12, 2015, 11:23 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124334/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 11:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> WIP: port away from QtQuick1
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 08ae3dacd7732d07283e742ee00af3be4bb9fe2b 
>   shell/AssistantButton.qml 586c1aa1ae8fe85eff364823fd90dd77daaeaacd 
>   shell/CMakeLists.txt 040b579bac2b1d3b113c7295170f1ef3159c858d 
>   shell/assistantpopup.h bdf331730b9b84c952935662a9a3529a9017a2d8 
>   shell/assistantpopup.cpp 9daa696e62350e2e47a2ac0361fb4a25786e33fd 
>   shell/assistantpopup.qml cc40a138049ae517099a55bc71e8effdef45a22d 
> 
> Diff: https://git.reviewboard.kde.org/r/124334/diff/
> 
> 
> Testing
> -------
> 
> compiles.
> 
> I no virtually nothing about QtQuick so feedback on the two #warnings is needed.
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150713/71af94e7/attachment.html>