Review Request 124329: Unit test framework with simple tests for variable rename

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124329/#review82427
-----------------------------------------------------------

Ship it!


pretty cool, I like it!


tests/CMakeLists.txt (line 90)
<https://git.reviewboard.kde.org/r/124329/#comment56813>

    just `endif()` is sufficient



tests/test_renamevar.cpp (line 57)
<https://git.reviewboard.kde.org/r/124329/#comment56814>

    std::bind? not sure, but using lambdas is nearly always the better choice - even Scott Meyers says so in his latest book.


- Milian Wolff


On July 11, 2015, 10:45 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124329/
> -----------------------------------------------------------
> 
> (Updated July 11, 2015, 10:45 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Unit test framework.
> 
> Fully transient
> 
> 
> Diffs
> -----
> 
>   refactoring/renamevardeclrefactoring.h PRE-CREATION 
>   refactoring/renamevardeclrefactoring.cpp PRE-CREATION 
>   tests/CMakeLists.txt 20d17efae9a2a77cd7ef76bf7484ccfcf12e4cd8 
>   tests/refactoringenvironment.h PRE-CREATION 
>   tests/refactoringenvironment.cpp PRE-CREATION 
>   tests/test_renamevar.h PRE-CREATION 
>   tests/test_renamevar.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/124329/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150712/5acabc9a/attachment-0001.html>