Review Request 124258: Added an interface to append child pages to the "Language support" config page

Sergey Kalinichev kalinichev.so.0 at gmail.com
Sun Jul 12 10:20:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124258/
-----------------------------------------------------------

(Updated July 12, 2015, 1:20 p.m.)


Review request for KDevelop.


Changes
-------

Here is a different approach: Instead of adding another method to the language support interface, let's add a notion of type to the ConfigPage.


Repository: kdevplatform


Description
-------

Now a config page that contains language specific settings can be appended as a child page to the "Language support" config page.

This is useful for e.g. kdev-clang plugin. See also https://git.reviewboard.kde.org/r/124139/


Diffs (updated)
-----

  interfaces/configpage.h aed5dd6 
  interfaces/configpage.cpp 939c9d9 
  shell/CMakeLists.txt cffa161 
  shell/configdialog.h 2bf7f77 
  shell/configdialog.cpp 1e2eaab 
  shell/languagecontroller.cpp d15a14b 
  shell/settings/ccconfig.kcfg  
  shell/settings/ccconfig.kcfgc 8fd94ca 
  shell/settings/ccpreferences.h a736c36 
  shell/settings/ccpreferences.cpp 9346e23 
  shell/settings/ccpreferences.ui 48bd90f 
  shell/settings/languageconfig.kcfgc PRE-CREATION 
  shell/uicontroller.cpp 6a662ce 

Diff: https://git.reviewboard.kde.org/r/124258/diff/


Testing
-------


File Attachments
----------------

LanguageSupport.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/05/ab17b5f1-b8c2-4383-8b0e-799f44dde14b__LanguageSupport.png


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150712/50651f1e/attachment.html>


More information about the KDevelop-devel mailing list