Review Request 124313: Port to KF5

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124313/#review82331
-----------------------------------------------------------


cool, but no idea about the settings stuff.


issue.cpp (line 23)
<https://git.reviewboard.kde.org/r/124313/#comment56683>

    namespace {
        inline QString defaultPath()
        {
            return QStringLiteral("...");
        }
        }



kdevkrazy2.json (line 56)
<https://git.reviewboard.kde.org/r/124313/#comment56684>

    remove



krazy2dialog.h (line 51)
<https://git.reviewboard.kde.org/r/124313/#comment56685>

    remove



krazy2dialog.cpp (line 49)
<https://git.reviewboard.kde.org/r/124313/#comment56687>

    style:
    
        switch (but) {
            case Ok:
                ret = ...;
                break;
            case Cancel:
                ...
        }



krazy2dialog.cpp (line 58)
<https://git.reviewboard.kde.org/r/124313/#comment56688>

    delete layout(); ?



krazy2view.cpp (line 215)
<https://git.reviewboard.kde.org/r/124313/#comment56689>

    rtrim



selectpathswidget.cpp (line 46)
<https://git.reviewboard.kde.org/r/124313/#comment56690>

    QStringLiteral



settings/krazy2preferences.cpp (line 29)
<https://git.reviewboard.kde.org/r/124313/#comment56691>

    indent : and put { on its own line



settings/krazy2preferences.cpp (line 53)
<https://git.reviewboard.kde.org/r/124313/#comment56692>

    QStringLiteral



settings/krazy2preferences.cpp (line 56)
<https://git.reviewboard.kde.org/r/124313/#comment56693>

    remove (everywhere?) - that should not be necessary anymore.



tests/CMakeLists.txt (line 13)
<https://git.reviewboard.kde.org/r/124313/#comment56694>

    there's a ecm macro for that, use that



tests/krazy2viewtest.cpp (line 2158)
<https://git.reviewboard.kde.org/r/124313/#comment56695>

    this is a test, so just calling processEvents here should be fine.



tests/krazy2viewtest.cpp (line 2391)
<https://git.reviewboard.kde.org/r/124313/#comment56696>

    don't you add methods for that below which you could use here, instead of duplicating the findChild code here?


- Milian Wolff


On July 10, 2015, 1:05 a.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124313/
> -----------------------------------------------------------
> 
> (Updated July 10, 2015, 1:05 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-krazy2
> 
> 
> Description
> -------
> 
> Ported the plugin to KF5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0d26b03 
>   analysisjob.cpp 13d47a4 
>   analysisresultsparser.cpp 41a6499 
>   checkerlistjob.cpp 3de323d 
>   issue.cpp d7525ee 
>   issuewidget.cpp cb78200 
>   kdevkrazy2.desktop f92e3ee 
>   kdevkrazy2.json PRE-CREATION 
>   krazy2dialog.h PRE-CREATION 
>   krazy2dialog.cpp PRE-CREATION 
>   krazy2plugin.h d362aff 
>   krazy2plugin.cpp 7c203d6 
>   krazy2view.h 16be779 
>   krazy2view.cpp 92b36ff 
>   krazy2view.ui c1d248c 
>   selectcheckerswidget.ui 2d4d0ec 
>   selectpathswidget.cpp 04bf270 
>   selectpathswidget.ui 252c9dd 
>   settings/CMakeLists.txt 874cb54 
>   settings/kcm_kdev_krazy2settings.desktop fe59f4a 
>   settings/krazy2config.kcfg 001f799 
>   settings/krazy2config.kcfgc c5bc909 
>   settings/krazy2preferences.h 96e80af 
>   settings/krazy2preferences.cpp b43d820 
>   tests/CMakeLists.txt 573c2c1 
>   tests/analysisjobtest.cpp bc672a0 
>   tests/analysisparameterstest.cpp 4c80683 
>   tests/analysisprogressparsertest.cpp d2cf9f6 
>   tests/analysisresultsparsertest.cpp c08ec35 
>   tests/analysisresultstest.cpp cbb0365 
>   tests/checkerlistjobtest.cpp aa46399 
>   tests/checkerlistparsertest.cpp 8fec279 
>   tests/checkermodeltest.cpp 124a5a5 
>   tests/checkertest.cpp d399af5 
>   tests/issuemodeltest.cpp cdf4de7 
>   tests/issuetest.cpp 25436a3 
>   tests/issuewidgettest.cpp a20bedf 
>   tests/krazy2viewtest.cpp beabcf9 
>   tests/selectcheckerswidgettest.cpp c27ea28 
>   tests/selectpathswidgettest.cpp 7dbbdfe 
>   tests/sortedissuesproxymodeltest.cpp 6d92b28 
> 
> Diff: https://git.reviewboard.kde.org/r/124313/diff/
> 
> 
> Testing
> -------
> 
> * It builds
> * It seems to work. See video https://www.youtube.com/watch?v=xx1aqh2lJr0
> * Doesn't seem to crash during work
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150710/62b3d7fa/attachment-0001.html>