Review Request 124300: Change signature
Maciej Poleski
d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com
Wed Jul 8 21:54:22 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124300/
-----------------------------------------------------------
Review request for KDevelop.
Repository: kdev-clang
Description
-------
Change signature refactoring
I decided not to implement rename function refactoring. Rename signature will provide this functionality.
We can rename all functions except constructors, destructors, conversion operators, operators.
This functionality is not finished. Currently it performs introspection of function prototype, extracts its return type, name and parameters.
After invocation displays dialog (ChangeSignatureDialog). This dialog allows to:
- change return type
- change function name
- change parameter types
and in near future will also allow:
- change order of parameters
- introduce new parameters
- remove existing parameters
After closing dialog, nothing happens. Transformation is not implemented yet.
Somewhere here should be screenshoot of this dialog...
Diffs
-----
refactoring/CMakeLists.txt PRE-CREATION
refactoring/changesignaturedialog.h PRE-CREATION
refactoring/changesignaturedialog.cpp PRE-CREATION
refactoring/changesignaturedialog.ui PRE-CREATION
refactoring/changesignaturerefactoring.h PRE-CREATION
refactoring/changesignaturerefactoring.cpp PRE-CREATION
refactoring/changesignaturerefactoringchangepack.h PRE-CREATION
refactoring/changesignaturerefactoringchangepack.cpp PRE-CREATION
refactoring/changesignaturerefactoringinfopack.h PRE-CREATION
refactoring/changesignaturerefactoringinfopack.cpp PRE-CREATION
refactoring/refactoring.h PRE-CREATION
refactoring/refactoring.cpp PRE-CREATION
refactoring/refactoringmanager.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/124300/diff/
Testing
-------
Manual testing of GUI. No transformation logic yet.
File Attachments
----------------
snapshot
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/08/e8a8db09-92f9-4fb6-ac4a-3ab2a5051033__snapshot1.png
Thanks,
Maciej Poleski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150708/71ca75a4/attachment.html>
More information about the KDevelop-devel
mailing list