Review Request 124242: Apply my KDevPlatform Problem API changes

Milian Wolff mail at milianw.de
Mon Jul 6 13:24:44 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124242/#review82129
-----------------------------------------------------------



languages/cpp/parser/control.h (line 46)
<https://git.reviewboard.kde.org/r/124242/#comment56431>

    It should be KDevelop::IProblem here, no? Is IProblem no in the KDevelop namespace? It should be.



languages/cpp/parser/parser.h (line 98)
<https://git.reviewboard.kde.org/r/124242/#comment56432>

    again, KDevelop::IProblem


- Milian Wolff


On July 4, 2015, 2:11 p.m., Laszlo Kis-Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124242/
> -----------------------------------------------------------
> 
> (Updated July 4, 2015, 2:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The patch simply applies my KDevPlatform Problem API changes. Diagnostics, Severity, Source...
> 
> 
> Diffs
> -----
> 
>   languages/cpp/cppduchain/contextbuilder.cpp 8aae468 
>   languages/cpp/cppduchain/expressionvisitor.cpp 2a6c981 
>   languages/cpp/cppduchain/missingdeclarationproblem.cpp 48c6e25 
>   languages/cpp/cppduchain/usebuilder.cpp 2315694 
>   languages/cpp/cppparsejob.cpp 73da755 
>   languages/cpp/parser/commentformatter.cpp 5c53a83 
>   languages/cpp/parser/control.h d197558 
>   languages/cpp/parser/control.cpp 07e197d 
>   languages/cpp/parser/lexer.cpp 31130d3 
>   languages/cpp/parser/parser.h 933e2c8 
>   languages/cpp/parser/parser.cpp 8c74f61 
>   languages/cpp/parser/tests/test_parser.cpp b7cfbcf 
>   languages/cpp/preprocessjob.cpp a196c67 
> 
> Diff: https://git.reviewboard.kde.org/r/124242/diff/
> 
> 
> Testing
> -------
> 
> * Builds.
> * Based on my empirical studies, it works as intended.
> *
> 
> 
> Thanks,
> 
> Laszlo Kis-Adam
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150706/5aabaadf/attachment.html>


More information about the KDevelop-devel mailing list