Review Request 124249: Greatly improve include-path completion performance

Sergey Kalinichev kalinichev.so.0 at gmail.com
Sat Jul 4 09:45:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124249/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdev-clang


Description
-------

Clang reparses a document without using PCH internally when editing file's preamble. This is very slow. So instead of locking ParseSession to prevent concurrent access to CXTranslationUnit (which include-path completion doesn't use), let's make ClangParsingEnvironment directly accessible through the session data.


Diffs
-----

  codecompletion/includepathcompletioncontext.cpp 34f613b 
  duchain/parsesession.h 74999de 
  duchain/parsesession.cpp cfafa33 

Diff: https://git.reviewboard.kde.org/r/124249/diff/


Testing
-------

I've been using this patch for more than a week. No side effects so far.


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150704/b96667d9/attachment.html>


More information about the KDevelop-devel mailing list