Review Request 124003: Speed up grep output view

[Oleksandr Senkovych]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124003/
-----------------------------------------------------------

(Updated July 3, 2015, 3:16 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Kevin Funk.


Changes
-------

Submitted with commit 1112a00f374a48608983ba89498965a9869bfb6e by Milian Wolff on behalf of Oleksandr Senkovych to branch master.


Repository: kdevplatform


Description
-------

Grep output view is very laggy if there is a lot of items. For example on my machine adding just 300 items to this view takes about 10 seconds and whole KDevelop UI becomes unresponsive. After applying proposed changes there is no problem to add even 10 000 items - everything works without any lag. 
Also, I didn't notice any regression in the UI: all rows in the view are displayed properly.


Diffs
-----

  plugins/grepview/grepoutputview.h 5191c58 
  plugins/grepview/grepoutputview.cpp 2fba779 
  plugins/grepview/grepviewplugin.h 29a4011 
  plugins/grepview/grepviewplugin.cpp 4226302 

Diff: https://git.reviewboard.kde.org/r/124003/diff/


Testing
-------


Thanks,

Oleksandr Senkovych

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150703/452db34c/attachment.html>