Review Request 124242: Apply my KDevPlatform Problem API changes
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Jul 3 13:40:25 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124242/#review82038
-----------------------------------------------------------
languages/cpp/cppduchain/environmentmanager.cpp (line 171)
<https://git.reviewboard.kde.org/r/124242/#comment56384>
it->toString
Same with the rest of `(*it).`
Looks good to me, can go in as soon as the kdevplatform side is ready.
- Aleix Pol Gonzalez
On July 3, 2015, 3:30 p.m., Laszlo Kis-Adam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124242/
> -----------------------------------------------------------
>
> (Updated July 3, 2015, 3:30 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> The patch simply applies my KDevPlatform Problem API changes. Diagnostics, Severity, Source...
>
>
> Diffs
> -----
>
> languages/cpp/cppduchain/contextbuilder.cpp 8aae468
> languages/cpp/cppduchain/cppduchain.cpp 9ec2eae
> languages/cpp/cppduchain/environmentmanager.cpp 21e2547
> languages/cpp/cppduchain/expressionvisitor.cpp 2a6c981
> languages/cpp/cppduchain/missingdeclarationproblem.cpp 48c6e25
> languages/cpp/cppduchain/usebuilder.cpp 2315694
> languages/cpp/cppparsejob.cpp 73da755
> languages/cpp/parser/commentformatter.cpp 5c53a83
> languages/cpp/parser/control.h d197558
> languages/cpp/parser/control.cpp 07e197d
> languages/cpp/parser/lexer.cpp 31130d3
> languages/cpp/parser/parser.h 933e2c8
> languages/cpp/parser/parser.cpp 8c74f61
> languages/cpp/parser/tests/test_parser.cpp b7cfbcf
> languages/cpp/preprocessjob.cpp a196c67
>
> Diff: https://git.reviewboard.kde.org/r/124242/diff/
>
>
> Testing
> -------
>
> * Builds.
> * Based on my empirical studies, it works as intended.
> *
>
>
> Thanks,
>
> Laszlo Kis-Adam
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150703/ba58a9d3/attachment.html>
More information about the KDevelop-devel
mailing list