Review Request 122322: custombuildsystem: More useful error messages when a custom tool is not setup

Nicolai Hähnle nhaehnle at gmail.com
Sat Jan 31 18:47:02 UTC 2015



> On Jan. 31, 2015, 5:54 nachm., Aleix Pol Gonzalez wrote:
> > projectmanagers/custom-buildsystem/custombuildjob.cpp, line 98
> > <https://git.reviewboard.kde.org/r/122322/diff/1/?file=345729#file345729line98>
> >
> >     Won't this end up with a weird word puzzle for translators to translate?

I suppose. Right now, I only see two alternatives: not mentioning the tool (i.e., just say "... for custom tool in project ..."), or having 5 complete strings for all 5 tools.


- Nicolai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122322/#review75084
-----------------------------------------------------------


On Jan. 29, 2015, 11:28 nachm., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122322/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 11:28 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> custombuildsystem: More useful error messages when a custom tool is not setup
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custom-buildsystem/CMakeLists.txt 7bb019ed100bfe02d1bfb19218a37adb4719f23c 
>   projectmanagers/custom-buildsystem/custombuildjob.h aad78cd0fd31993143dad60d681182901efedaad 
>   projectmanagers/custom-buildsystem/custombuildjob.cpp 3677fcf3a62a638e357031adb341e834c3197c21 
>   projectmanagers/custom-buildsystem/custombuildsystemconfig.h 0a8c3f163868a9fc039f91f6fd70d6f99ee014ae 
>   projectmanagers/custom-buildsystem/custombuildsystemconfig.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150131/8a27ae77/attachment-0001.html>


More information about the KDevelop-devel mailing list