Review Request 122333: Pass translated format string arguments directly into i18n() functions

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122333/#review75081
-----------------------------------------------------------

Ship it!


Good catch!!!

- Aleix Pol Gonzalez


On Jan. 31, 2015, 12:33 a.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122333/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2015, 12:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This avoids ugly "(I18N_ARGUMENT_MISSING)" annotations in copied frame stacks.
> 
> The "I18N_ARGUMENT_MISSING" appears to have been a change in behavior in either recent Qt or recent KF5 libs - I don't follow their development closely enough to tell.
> 
> I'm submitting this as a review to highlight the issue, since it is virtually guaranteed to affect other parts of the code as well. Is there some automatic tool to check for incorrect use of i18n()?
> 
> 
> Diffs
> -----
> 
>   debugger/framestack/framestackwidget.cpp 3998e418b8c7f6c5af3483ef515582ae7578b09a 
> 
> Diff: https://git.reviewboard.kde.org/r/122333/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150131/49cf1a5d/attachment.html>