Review Request 122169: Use oldcpp behavior when inserting include paths.

[Milian Wolff]

> On Jan. 21, 2015, 2:13 p.m., Sergey Kalinichev wrote:
> > codecompletion/includepathcompletioncontext.cpp, line 151
> > <https://git.reviewboard.kde.org/r/122169/diff/1/?file=343477#file343477line151>
> >
> >     Here: https://git.reviewboard.kde.org/r/120241/
> >     were mentioned that "#   include" is valid too. I think that we still should support it.

indeed, the unit test is lacking in that regard. I'll extend it and ensure this works.


> On Jan. 21, 2015, 2:13 p.m., Sergey Kalinichev wrote:
> > codecompletion/includepathcompletioncontext.cpp, line 162
> > <https://git.reviewboard.kde.org/r/122169/diff/1/?file=343477#file343477line162>
> >
> >     Actually I don't like how oldcpp removes the whole line, including comments. I think that we shouldn't remove anything after closing " or >

Again, something that the unit test is not yet checking. I agree it should work as you say. I'll extend this patch and add a test.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122169/#review74477
-----------------------------------------------------------


On Jan. 20, 2015, 12:51 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122169/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 12:51 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This is much better, in my opinion. It allows one to easily include
> long paths as well as change existing includes more easily as the
> rest of the line gets removed as well.
> 
> 
> Diffs
> -----
> 
>   codecompletion/includepathcompletioncontext.cpp 9dea2879418c4f81ab1927d848c831b092bd11e6 
> 
> Diff: https://git.reviewboard.kde.org/r/122169/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150121/7fadf31a/attachment-0001.html>