Review Request 122162: Trigger a reparse from code completion if required.

[Milian Wolff]

> On Jan. 21, 2015, 2:22 p.m., Sergey Kalinichev wrote:
> > codecompletion/model.cpp, line 123
> > <https://git.reviewboard.kde.org/r/122162/diff/1/?file=343441#file343441line123>
> >
> >     I'm having that problem when re-opening  KDevelop with some documents opened in editor. When doing so, for some reasons AST gets attached only for some contexts. 
> >       So I think it should be fixed there instead. I.e. if document is opened in editor and no ast attached, create one. I think that isUpdateRequired is the culprit here.
> >       Or is it another bug? And sessionData in code completion can be empty in some other situations?

Yeah, I think what you are talking about is something different. Note how the above explictly requests the AST, so it should always add the sessionData. 

When you just reopen a KDevelop instance, the project import will not see any changes and nothing happens. Only with this patch, and only after you requested code completion once, will the AST be added. There is certainly room for improvement. Something like ensuring the active document gets an AST associated after restart, but no DUChain is updated.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122162/#review74478
-----------------------------------------------------------


On Jan. 20, 2015, 1:24 a.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122162/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 1:24 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Needs some logic to automatically display the code completion list
> afterwards then. But still, better than nothing.
> 
> 
> Diffs
> -----
> 
>   codecompletion/model.cpp 0dcf44cdc801f7c4f330b9137e08f4f54da37b9d 
> 
> Diff: https://git.reviewboard.kde.org/r/122162/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150121/4bc6de6c/attachment.html>