Review Request 122164: Cache custom includes in main thread

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122164/#review74376
-----------------------------------------------------------


Yes, I think this is the correct solution, I looked at it yesterday as well but didn't finish writing it. I think you need a mutex though to access the list, otherwise you could get problems with another parse job accessing the list while you copy data into it.
Thanks!

- Sven Brauch


On Jan. 20, 2015, 8:10 a.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122164/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 8:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Custom includes can't be obtained in the background thread, we must
> cache it from main thread.
> 
> 
> Diffs
> -----
> 
>   duchain/helpers.h d0212414a7c6dbf2a3bf251216632673d7fb32bd 
>   duchain/helpers.cpp a252d7cccac9aa1f563f5539060a071e88ced9c9 
>   pythonparsejob.cpp cc50eebfa3fd75817010ff70fcd4f621cbe89346 
> 
> Diff: https://git.reviewboard.kde.org/r/122164/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150120/8b992c81/attachment.html>