Review Request 122145: Cache defines/includes on-demand.

Kevin Funk kfunk at kde.org
Mon Jan 19 14:16:43 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122145/#review74327
-----------------------------------------------------------

Ship it!


So my QElapsedTimer in the plugin controller already payed off :)

But indeed, I was noticing the slow init speed for this plugin, too.

- Kevin Funk


On Jan. 19, 2015, 1:24 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122145/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 1:24 p.m.)
> 
> 
> Review request for KDevelop and Sergey Kalinichev.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This improves startup speed as we can load the defines/includes
> plugin much quicker now. Furthermore, we only initialize the
> includes/defines for the compiler(s) that are actually used,
> not all available ones, thus decreasing memory consumption.
> 
> Before:
> Successfully loaded plugin "KDevDefinesAndIncludesManager" from
> ...kdevplatform/21/kdevdefinesandincludesmanager.so" - took: 200 ms
> 
> After:
> Successfully loaded plugin "KDevDefinesAndIncludesManager" from
> ...kdevplatform/21/kdevdefinesandincludesmanager.so" - took: 20 ms
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp bc99d8d45fdc0cbfbbf793166bf12d0e882cc27b 
> 
> Diff: https://git.reviewboard.kde.org/r/122145/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150119/fe1bb399/attachment.html>


More information about the KDevelop-devel mailing list