Review Request 121779: Select language/standard for parsing from config file

Kevin Funk kfunk at kde.org
Mon Jan 19 11:11:55 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121779/#review74306
-----------------------------------------------------------



duchain/clangparsingenvironment.h
<https://git.reviewboard.kde.org/r/121779/#comment51583>

    Well, no. But does ClangParsingEnvironment need to know about the meaning of this and future additional flags? Probably not.
    
    Anyway, leave it like that, I don't have a strong opinion on it.


- Kevin Funk


On Jan. 19, 2015, 11:02 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121779/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2015, 11:02 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> With this kdev-clang can parse C++ files even if the file extension is .c/.h. And vice-versa
> Also the language standard now is configurable.
> 
> Note: this review depends on https://git.reviewboard.kde.org/r/121777/
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 21c71b8 
>   duchain/clangparsingenvironment.h c9be2d3 
>   duchain/clangparsingenvironment.cpp 0d27d1e 
>   duchain/parsesession.cpp a30422b 
> 
> Diff: https://git.reviewboard.kde.org/r/121779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150119/71ae17b2/attachment.html>


More information about the KDevelop-devel mailing list