Review Request 121779: Select language/standard for parsing from config file

[Sergey Kalinichev]

> On Jan. 16, 2015, 2:21 a.m., Kevin Funk wrote:
> > clangparsejob.cpp, line 142
> > <https://git.reviewboard.kde.org/r/121779/diff/2/?file=339283#file339283line142>
> >
> >     `return readEntry("Standard", QStringLiteral("c++11"))`?

Yes. I know. But it can return an empty string anyway. I've added a comment about that.


> On Jan. 16, 2015, 2:21 a.m., Kevin Funk wrote:
> > duchain/clangparsingenvironment.h, line 106
> > <https://git.reviewboard.kde.org/r/121779/diff/2/?file=339284#file339284line106>
> >
> >     I'd generalize this, let's do a 'additionalArgs' property instead.

Why? additionalArgs doesn't say anything about what it is. Also if in the future we'll add another property, what to call it then? additionalArgs2 ??


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121779/#review74106
-----------------------------------------------------------


On Jan. 9, 2015, 3:46 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121779/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 3:46 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> With this kdev-clang can parse C++ files even if the file extension is .c/.h. And vice-versa
> Also the language standard now is configurable.
> 
> Note: this review depends on https://git.reviewboard.kde.org/r/121777/
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 5c11abb 
>   duchain/clangparsingenvironment.h 97ea297 
>   duchain/clangparsingenvironment.cpp f73822f 
>   duchain/parsesession.cpp 8f3a43c 
> 
> Diff: https://git.reviewboard.kde.org/r/121779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150119/9ab264c0/attachment.html>