Review Request 122110: Do not create the session data twice when nothing can be updated.

Sergey Kalinichev kalinichev.so.0 at gmail.com
Sun Jan 18 13:24:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122110/#review74236
-----------------------------------------------------------



clangparsejob.cpp
<https://git.reviewboard.kde.org/r/122110/#comment51546>

    +1. I was puzzled by that part of the code, now it's evident what it does.


- Sergey Kalinichev


On Jan. 17, 2015, 9:40 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122110/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 9:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Do not create the session data twice when nothing can be updated.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 21c71b8eaae19b633349f9245cee44e56d7783e7 
>   duchain/clangparsingenvironment.cpp f73822f880233bff73807e33d7bc209946992c0d 
> 
> Diff: https://git.reviewboard.kde.org/r/122110/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150118/5ba03327/attachment.html>


More information about the KDevelop-devel mailing list