Review Request 122122: Use a QOldSchoolPointer Inside BranchesListModelPrivate

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122122/#review74223
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Funk


On Jan. 18, 2015, 7:27 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122122/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2015, 7:27 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This model is fed with *the* DVC plugin (see BranchManager::BranchManager) so when the model falls out of scope it deletes what it should not delete.
> 
> 
> Diffs
> -----
> 
>   vcs/models/brancheslistmodel.cpp 977beca 
> 
> Diff: https://git.reviewboard.kde.org/r/122122/diff/
> 
> 
> Testing
> -------
> 
> 1. Open a git-controlled project
> 2. Check the branches (Right click->Git->Branches...)
> 3. Close the branches list
> 4. Right click on the project again
> 
> Before this patch, 4. crashes KDevelop. You can also see debug output that reads "<mem address> deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes". After this patch, no crash happens (at least none related to DVC plugin).
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150118/802c55d3/attachment-0001.html>