Review Request 122111: Share cached ParseSessionData with all files in the translation unit.

Milian Wolff mail at milianw.de
Sat Jan 17 17:43:33 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122111/#review74189
-----------------------------------------------------------


the problem I have with this, is that often no file is open at all. or system headers are pinned to some completely other TU that is currently not being worked on. still, better than nothing. We should now also be able to remove some code duplication in e.g. the signature assistant, which should now assume that both, header and source are part of the same TU. furthermore, the code completion should also be looking for the parsesession data in the context of the TU url for the current document, which is relevant when we open a .h for a .cpp after that was parsed.

- Milian Wolff


On Jan. 17, 2015, 5:40 p.m., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122111/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2015, 5:40 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This still only applies to files open in the editor but already
> helps there to share the data between header and implementation e.g.
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 21c71b8eaae19b633349f9245cee44e56d7783e7 
>   duchain/parsesession.h 6cf0dea8e53a9c6fb35a37e1778eac78f273d0d4 
> 
> Diff: https://git.reviewboard.kde.org/r/122111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150117/68aff63d/attachment.html>


More information about the KDevelop-devel mailing list