Review Request 121779: Select language/standard for parsing from config file

Kevin Funk kfunk at kde.org
Thu Jan 15 22:21:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121779/#review74106
-----------------------------------------------------------



clangparsejob.cpp
<https://git.reviewboard.kde.org/r/121779/#comment51473>

    `return readEntry("Standard", QStringLiteral("c++11"))`?



duchain/clangparsingenvironment.h
<https://git.reviewboard.kde.org/r/121779/#comment51474>

    I'd generalize this, let's do a 'additionalArgs' property instead.



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/121779/#comment51479>

    Doesn't this whole change in `argsForSession` mean that we'll now parse the full project in *either* C- or C++-mode? That's not what we want. We still want to decide the parse-mode based on the mime type.
    
    We should introduce language standard version settings *per language* (C/C++/ObjC(++)), instead of *per compiler*.


- Kevin Funk


On Jan. 9, 2015, 11:46 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121779/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 11:46 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> With this kdev-clang can parse C++ files even if the file extension is .c/.h. And vice-versa
> Also the language standard now is configurable.
> 
> Note: this review depends on https://git.reviewboard.kde.org/r/121777/
> 
> 
> Diffs
> -----
> 
>   clangparsejob.cpp 5c11abb 
>   duchain/clangparsingenvironment.h 97ea297 
>   duchain/clangparsingenvironment.cpp f73822f 
>   duchain/parsesession.cpp 8f3a43c 
> 
> Diff: https://git.reviewboard.kde.org/r/121779/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150115/152c1cfc/attachment.html>


More information about the KDevelop-devel mailing list