Review Request 121681: Fix compilation
Milian Wolff
mail at milianw.de
Wed Jan 14 18:17:29 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121681/#review74023
-----------------------------------------------------------
Ship it!
Ship It!
- Milian Wolff
On Jan. 14, 2015, 5:32 p.m., Jakub Caban wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121681/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 5:32 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdev-upload
>
>
> Description
> -------
>
> Just a few porting bits to make it compile again without KDELibs4Support:
> - port away from KIcon
> - port away from KIO::NetAccess
> - kDebug() -> qDebug() (actually I've enforced kDebug(int) -> qDebug() as I found no reason to keep that categorization in one place. If I'm mistaken let me know)
>
>
> Diffs
> -----
>
> uploadprofileitem.cpp f957ce4
> profilesfiletree.cpp 45152f6
> uploaddialog.cpp 8d0c7a1
> uploadjob.cpp ebe556b
> uploadpreferences.cpp 1fe0d72
> uploadprofiledlg.cpp ac0fba2
> allprofilesmodel.cpp 3ee6053
> kdevuploadplugin.cpp 3f05752
> uploadprojectmodel.cpp c7ddacf
> uploadprofilemodel.cpp bc5153f
>
> Diff: https://git.reviewboard.kde.org/r/121681/diff/
>
>
> Testing
> -------
>
> Compiles and works in simple cases I've tried.
>
>
> Thanks,
>
> Jakub Caban
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150114/cb76826b/attachment.html>
More information about the KDevelop-devel
mailing list