Review Request 121964: Make the BranchesListModel public
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jan 12 16:28:30 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121964/#review73875
-----------------------------------------------------------
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Jan. 12, 2015, 1:57 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121964/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 1:57 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevplatform
>
>
> Description
> -------
>
> Currently the header file of BranchesListModel isn't being installed, but from the code
> it seems that the intetion was to offer BranchesListModel as a public class.
>
> This patch changes this behaviour by installing the header file of BranchesListModel and
> also the class is now using a d-pointer.
>
>
> Diffs
> -----
>
> vcs/CMakeLists.txt 1376bc8
> vcs/models/brancheslistmodel.h 66ead9e
> vcs/models/brancheslistmodel.cpp 03d3d3b
>
> Diff: https://git.reviewboard.kde.org/r/121964/diff/
>
>
> Testing
> -------
>
> a. create a new project with plasmate
> b. create a new branch
> c. switch to the new branch
>
> it worked.
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150112/7e98a003/attachment.html>
More information about the KDevelop-devel
mailing list