Review Request 121964: Make the BranchesListModel public
Giorgos Tsiapaliokas
giorgos.tsiapaliokas at kde.org
Mon Jan 12 13:57:01 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121964/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 3:57 p.m.)
Review request for KDevelop.
Changes
-------
The new patchset is fixing the issues
Repository: kdevplatform
Description
-------
Currently the header file of BranchesListModel isn't being installed, but from the code
it seems that the intetion was to offer BranchesListModel as a public class.
This patch changes this behaviour by installing the header file of BranchesListModel and
also the class is now using a d-pointer.
Diffs (updated)
-----
vcs/CMakeLists.txt 1376bc8
vcs/models/brancheslistmodel.h 66ead9e
vcs/models/brancheslistmodel.cpp 03d3d3b
Diff: https://git.reviewboard.kde.org/r/121964/diff/
Testing
-------
a. create a new project with plasmate
b. create a new branch
c. switch to the new branch
it worked.
Thanks,
Giorgos Tsiapaliokas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150112/90274813/attachment.html>
More information about the KDevelop-devel
mailing list