Review Request 121984: Add project to CompilerProvider when includes/defines asked for

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121984/#review73824
-----------------------------------------------------------

Ship it!


while I dislike const_cast's, I don't see a better alternative. Thanks Sergey, I think this should hopefully fix the last issues with this piece of code!


languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
<https://git.reviewboard.kde.org/r/121984/#comment51346>

    I'd rename projectOpened now to something like addProject or such.


- Milian Wolff


On Jan. 11, 2015, 3:08 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121984/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2015, 3:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Oterwise, because of projectAboutToBeApened signal isn't emitted for some reasons, we could end up in the situation when project is not yet added to CompilerProvider, but the BackgroundParser already began parsing the project.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp 3643e78 
> 
> Diff: https://git.reviewboard.kde.org/r/121984/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150112/8151f785/attachment-0001.html>