Review Request 121881: Greatly cleanup PluginController::loadPluginInternal.

[Nicolai Hähnle]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121881/#review73260
-----------------------------------------------------------


Looks good to me.

Stylistic nitpick: the if-statements aren't consistently formatted (spaces outside vs. inside the parentheses).

Also, while you guys are at it, do you think you could add some UI feedback for when loading a plugin fails? Currently, when a plugin fails to load, the only indication in the UI is that in the Plugins page of Configure KDevelop, the plugin becomes disabled - and it reverts to being disabled if one tries to enable it manually. That's really not ideal...

- Nicolai Hähnle


On Jan. 6, 2015, 12:50 nachm., Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121881/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 12:50 nachm.)
> 
> 
> Review request for KDevelop and Sergey Kalinichev.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This hopefully resolves some issues in understanding the flow of
> this method. Some code could also be removed and the warning
> messages better formatted.
> 
> 
> Diffs
> -----
> 
>   shell/plugincontroller.cpp f70fc646e00e257bc0cd0a401cd8106569e23181 
> 
> Diff: https://git.reviewboard.kde.org/r/121881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Milian Wolff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150106/e051e230/attachment-0001.html>