Review Request 121880: FocusedTreeView: use a timer to batch recomputations of column width

Nicolai Hähnle nhaehnle at gmail.com
Tue Jan 6 11:58:29 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121880/
-----------------------------------------------------------

Review request for KDevelop.


Repository: kdevplatform


Description
-------

We need to recompute the column width when a new row is inserted to ensure that
the horizontal scrollbar behaves properly.

Under certain circumstances (in particular: running an extremely spammy process
or filtering large outputs), rowInserted is called many times in quick succession,
which leads to essentially quadratic runtime behavior, because some of the
recomputation triggers a slow layout recomputation inside QTreeView. So we delay
the recomputation until we get back to the event loop.

After this change, output views work smoothly even on very large outputs.


Diffs
-----

  util/focusedtreeview.h f813c2de6d8679c57c1477d8bc63c29e2139ba98 
  util/focusedtreeview.cpp b58720313cc9c3ca08ae401c009425a30cdc326a 

Diff: https://git.reviewboard.kde.org/r/121880/diff/


Testing
-------


Thanks,

Nicolai Hähnle

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150106/301f5d1b/attachment.html>


More information about the KDevelop-devel mailing list