Review Request 121775: Correctly load dependencies for plugins

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121775/
-----------------------------------------------------------

(Updated Jan. 5, 2015, 4:30 p.m.)


Review request for KDevelop.


Changes
-------

Fixed another bug: dependenciesForPlugin must check loaded plugins(instead of all available) for satisfied dependencies.
Use QSet everywhere


Repository: kdevplatform


Description (updated)
-------

It fixes 2 bugs:

1) checkForDependencies returns false if there are some dependencies, but the code that calls this method threats false return code as an error, so it doesn't try to load any dependencies at all.
2) checkForDependencies must check loaded plugins (instead of all available) for satisfied dependencies. As a result currently it almost always returns true

So because of these 2 bugs interconnected currently everything works.


Diffs (updated)
-----

  shell/plugincontroller.h 89b0b8b 
  shell/plugincontroller.cpp f70fc64 

Diff: https://git.reviewboard.kde.org/r/121775/diff/


Testing
-------


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150105/041b0f0c/attachment.html>