Review Request 121808: Add IBSM::hasIncludesOrDefines

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jan 5 00:19:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121808/#review73101
-----------------------------------------------------------



project/interfaces/ibuildsystemmanager.h
<https://git.reviewboard.kde.org/r/121808/#comment50843>

    Sorry for the nitpicking, but should we call it isFileManaged(ProjectFileItem* item)?


- Aleix Pol Gonzalez


On Jan. 4, 2015, 12:07 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121808/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2015, 12:07 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> IBSM::hasIncludesOrDefines is needed to check whether a given file has information from the buildsystem.
> 
> 
> Diffs
> -----
> 
>   project/interfaces/ibuildsystemmanager.h 2be2c43 
> 
> Diff: https://git.reviewboard.kde.org/r/121808/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150105/b6a5aa0a/attachment.html>


More information about the KDevelop-devel mailing list