Review Request 121812: IExecutePlugin: rename dependecyJob into dependencyJob (typo fix, API breaking)

Milian Wolff mail at milianw.de
Sat Jan 3 18:58:04 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121812/#review73042
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On Jan. 3, 2015, 6:44 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121812/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 6:44 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This requires trivial changes to some plugins; if a plugin is not updated,
> it will fail to compile (since dependencyJob is a pure virtual method), so
> there is no danger of accidentally introducing hidden bugs.
> 
> 
> Diffs
> -----
> 
>   plugins/execute/nativeappconfig.cpp 0cd40f41b2572fa563e1a42d7831ac809dd44380 
>   plugins/execute/executeplugin.h 2dea4e43af364d0032d19695b8d92567e6992e83 
>   plugins/execute/executeplugin.cpp d2aa84c645ec067303463cb93a272867ec60f0bf 
>   plugins/execute/iexecuteplugin.h 8eecc03ae94d51bcfc862e07c8a9df268c33028d 
> 
> Diff: https://git.reviewboard.kde.org/r/121812/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/036b14bd/attachment.html>


More information about the KDevelop-devel mailing list