Review Request 121794: BreakpointModel: load and save from session instead of from global configuration

[Nicolai Hähnle]

> On Jan. 3, 2015, 1:37 nachm., Milian Wolff wrote:
> > Can you apply this to the 1.7 branch and we merge it up to master, or does it depent too much on the other refactorings you did in msater?
> > 
> > thanks in any case :)

The patch itself should apply quite cleanly to the 1.7 branch. One issue though: Technically, adding the m_dirty member is an ABI-breaking change. I _think_ that it's _probably_ fine in practice, since the `BreakpointModel` is only allocated and deleted by the `DebugController` within kdevplatform itself - at least within standard KDevelop and the plugins I'm aware of - and there are no inline methods defined in the header, and I am not aware of any derived classes. So I believe all the code that relies on the memory layout of BreakpointModel is in kdevplatform. What do you think?

(Converting the BreakpointModel and Breakpoint classes to use a d-pointer is on my todo list...)


- Nicolai


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121794/#review73004
-----------------------------------------------------------


On Jan. 2, 2015, 8:52 nachm., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121794/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2015, 8:52 nachm.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> BUG: 336773
> 
> 
> Diffs
> -----
> 
>   debugger/breakpoint/breakpointmodel.h afab32b9850fc0942bf15fd45dbc82814350e182 
>   debugger/breakpoint/breakpointmodel.cpp 360bb2fa69b85c696bdd6acc02362b317911d1f9 
>   shell/debugcontroller.cpp 823d3c8ff752539d1ad0e2b57c4f614235699eaa 
> 
> Diff: https://git.reviewboard.kde.org/r/121794/diff/
> 
> 
> Testing
> -------
> 
> manual testing
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/82aabb2e/attachment.html>