Review Request 121809: Implement IBSM::hasIncludesOrDefines

[Olivier Jean de Gaalon]

> On Jan. 3, 2015, 4:17 p.m., Aleix Pol Gonzalez wrote:
> > projectmanagers/custommake/custommakemanager.cpp, line 174
> > <https://git.reviewboard.kde.org/r/121809/diff/1/?file=337974#file337974line174>
> >
> >     Also in this case, it might have includes or defines...

I'd prefer to add a TODO here than to implement this for CustomMakeManager


- Olivier Jean de


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121809/#review73029
-----------------------------------------------------------


On Jan. 3, 2015, 4:10 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121809/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 4:10 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Implementation of KDevplatform IBSM changes from #121808
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custommake/custommakemanager.h 552961c 
>   projectmanagers/custommake/custommakemanager.cpp 552749d 
>   projectmanagers/cmake/cmakemanager.h 4942b4b 
>   projectmanagers/cmake/cmakemanager.cpp a8d3705 
>   projectmanagers/custom-buildsystem/custombuildsystemplugin.h e3fa00c 
>   projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp 602353c 
> 
> Diff: https://git.reviewboard.kde.org/r/121809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/09278a44/attachment.html>