Review Request 121809: Implement IBSM::hasIncludesOrDefines

[Milian Wolff]

> On Jan. 3, 2015, 4:17 p.m., Aleix Pol Gonzalez wrote:
> > projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp, line 71
> > <https://git.reviewboard.kde.org/r/121809/diff/1/?file=337972#file337972line71>
> >
> >     Why always false?
> >     It will depend on the defined information no?
> >     
> >     Also in fact, there will always be some provided by the compiler...

the compiler info is unrelated to the IBSM stuff. the IDAIM takes care of compiler stuff.

and always false b/c the plugin currently has no way to know includes or defines. it always returns an empty list. it leverages the custom includes/defines plugin instead


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121809/#review73029
-----------------------------------------------------------


On Jan. 3, 2015, 4:10 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121809/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2015, 4:10 p.m.)
> 
> 
> Review request for KDevelop, Aleix Pol Gonzalez and Milian Wolff.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Implementation of KDevplatform IBSM changes from #121808
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custommake/custommakemanager.h 552961c 
>   projectmanagers/custommake/custommakemanager.cpp 552749d 
>   projectmanagers/cmake/cmakemanager.h 4942b4b 
>   projectmanagers/cmake/cmakemanager.cpp a8d3705 
>   projectmanagers/custom-buildsystem/custombuildsystemplugin.h e3fa00c 
>   projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp 602353c 
> 
> Diff: https://git.reviewboard.kde.org/r/121809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150103/6276985c/attachment.html>