Review Request 121775: Correctly load dependencies for plugins

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121775/#review72894
-----------------------------------------------------------

Ship it!


Good job!
It looks safe to get this in, especially if the same unit tests passed both on kdevplatform and kdevelop.

Some nitpicking:


shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121775/#comment50746>

    endl is not needed



shell/plugincontroller.cpp
<https://git.reviewboard.kde.org/r/121775/#comment50747>

    You've used nullptr on the rest...


- Aleix Pol Gonzalez


On Dec. 31, 2014, 12:34 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121775/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 12:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Currently if some plugin depends on another one that's not yet loaded, the former one won't be loaded too.
> 
> This happens because checkForDependencies returns false if there are some dependencies, but the code that calls this method threats false return code as an error, so it doesn't try to load any dependencies at all.
> 
> 
> Diffs
> -----
> 
>   shell/plugincontroller.h 89b0b8b 
>   shell/plugincontroller.cpp f70fc64 
> 
> Diff: https://git.reviewboard.kde.org/r/121775/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150102/25f8a64a/attachment.html>