Review Request 122758: [OS X] work around missing Q_COMPILER_INITIALIZER_LISTS
René J.V. Bertin
rjvbertin at gmail.com
Sat Feb 28 17:03:42 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122758/
-----------------------------------------------------------
Review request for KDE Software on Mac OS X and KDevelop.
Repository: kdev-python
Description
-------
OS X lacks (full) support for compiler initialiser lists, i.e. Q_COMPILER_INITIALIZER_LISTS is not defined. As a result, several expressions used in kdev-python C++ code fail to compile.
This patch presents a workaround. I have used dynamically allocated class instances where an initialiser list is returned from a function, to avoid returning references to out-of-scope objects.
Please correct me if there are better ways, or if that means the objects have to deleted explicitly by the caller in order to prevent memory leaks.
Diffs
-----
duchain/tests/pyduchaintest.cpp 173a5cb
pythonlanguagesupport.cpp d8a720f
duchain/contextbuilder.cpp 40e344b
Diff: https://git.reviewboard.kde.org/r/122758/diff/
Testing
-------
On OS X/MacPorts with KDE libs 4.14.5 and KDevelop 4.7.1 .
Thanks,
René J.V. Bertin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150228/049ece6e/attachment.html>
More information about the KDevelop-devel
mailing list