Review Request 122727: Added option to enable/disable bold style from declarations.

[Miquel Sabaté Solà]

> On Feb. 26, 2015, 3:04 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't this be up to the language implementation? I don't think it's something up to the user to configure more than it's Ruby where the declaration concept doesn't make that much sense in practice...
> 
> Kevin Funk wrote:
>     I had the same thoughts, but then again, there seem to be quite a few users being put off by the bold font *in general*, according to https://bugs.kde.org/show_bug.cgi?id=294819.
>     
>     But it probably makes sense to allow *languages* to disable it completely, regardless of what the user configured. Maybe by adding a corresponding flag in ILanguageSupport. Thoughts?
> 
> Miquel Sabaté Solà wrote:
>     Not really. I said at first that this is specially useful in languages such as Ruby or PHP, but I'd also want this in C++ and in any language really (see the bug reports, they are not talking about specific languages either). Moreover, I can see people prefering "the old way" for Ruby or Python too.
>     
>     So, regardless of the language, some people might want to have it enabled, and some ohers disabled. Therefore, this should be configurable, not implemented by language plugins.
> 
> Aleix Pol Gonzalez wrote:
>     Well, I don't really agree, I don't think it's that much about what people want but about what makes sense.
> 
> Kevin Funk wrote:
>     Well, I don't think it's bad to allow to disable it. We generally have *very* few options for an IDE, too few at times, I think.
>     
>     Let's choose sane defaults, but allow people to override them.

@Aleix Yes, I know. But in this case it makes sense imho. KDevelop will change your fonts & color schemas in two ways:

1. It will apply semantic highlighting, thus overriding the colors as defined by your color schema.
2. It will make declarations bold.

The first point is configurable right now through "Local colorization intensity" and "Global colorization intensity". But before this patch we could not address the second point. That's inconsistent, and it leads to situations like: "I don't want KDevelop touching anything about my color schema" (as you can see in the bug reports) or "I like semantic highlighting, but I don't like that KDevelop is changing my fonts (aka bold in some cases)" (this was my original problem). 

After this patch, we have that a user can decide what can KDevelop touch about its schema and fonts.


- Miquel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122727/#review76667
-----------------------------------------------------------


On Feb. 26, 2015, 2:38 p.m., Miquel Sabaté Solà wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122727/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2015, 2:38 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 234898 and 294819
>     http://bugs.kde.org/show_bug.cgi?id=234898
>     http://bugs.kde.org/show_bug.cgi?id=294819
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> I've added a configurable option for the semantic highlighting in which the user can deactivate a bold style for declarations. This is specially useful for languages such as Ruby or PHP in which the difference between a declaration and a use is narrower than in languages like C. By default this option is set to true, which is the behavior that we had before this patch. I've uploaded some images too.
> 
> 
> Diffs
> -----
> 
>   interfaces/icompletionsettings.h c41ee20 
>   language/highlighting/codehighlighting.cpp 918038b 
>   language/highlighting/colorcache.h d021fd2 
>   language/highlighting/colorcache.cpp 5494be1 
>   shell/completionsettings.h e441319 
>   shell/completionsettings.cpp 0440ca7 
>   shell/settings/ccconfig.kcfg 1cd72a4 
>   shell/settings/ccpreferences.ui fa4559e 
> 
> Diff: https://git.reviewboard.kde.org/r/122727/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> File Attachments
> ----------------
> 
> Bold declarations
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/2a291537-8ad4-4d61-b287-4b5a0973eeba__before.png
> Without bold declarations
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/a208ddcd-ea43-4403-ac7c-bb1f18e04056__after.png
> Configuration dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/236ada26-d6f5-4395-a5f6-6bf7bbb46969__cfg.png
> 
> 
> Thanks,
> 
> Miquel Sabaté Solà
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150226/36db8a60/attachment-0001.html>