Review Request 122727: Added option to enable/disable bold style from declarations.

[Miquel Sabaté Solà]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122727/
-----------------------------------------------------------

(Updated Feb. 26, 2015, 2:38 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Bugs: 234898 and 294819
    http://bugs.kde.org/show_bug.cgi?id=234898
    http://bugs.kde.org/show_bug.cgi?id=294819


Repository: kdevplatform


Description
-------

I've added a configurable option for the semantic highlighting in which the user can deactivate a bold style for declarations. This is specially useful for languages such as Ruby or PHP in which the difference between a declaration and a use is narrower than in languages like C. By default this option is set to true, which is the behavior that we had before this patch. I've uploaded some images too.


Diffs
-----

  interfaces/icompletionsettings.h c41ee20 
  language/highlighting/codehighlighting.cpp 918038b 
  language/highlighting/colorcache.h d021fd2 
  language/highlighting/colorcache.cpp 5494be1 
  shell/completionsettings.h e441319 
  shell/completionsettings.cpp 0440ca7 
  shell/settings/ccconfig.kcfg 1cd72a4 
  shell/settings/ccpreferences.ui fa4559e 

Diff: https://git.reviewboard.kde.org/r/122727/diff/


Testing
-------

Manual testing.


File Attachments
----------------

Bold declarations
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/2a291537-8ad4-4d61-b287-4b5a0973eeba__before.png
Without bold declarations
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/a208ddcd-ea43-4403-ac7c-bb1f18e04056__after.png
Configuration dialog
  https://git.reviewboard.kde.org/media/uploaded/files/2015/02/26/236ada26-d6f5-4395-a5f6-6bf7bbb46969__cfg.png


Thanks,

Miquel Sabaté Solà

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150226/6357d4d8/attachment.html>