Review Request 122658: Adds ClangFormat to kdevcustomscript_plugin

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122658/#review76645
-----------------------------------------------------------


Generally looking good to me. Please update the patch and then we can probably merge this as-is.


formatters/customscript/customscript_plugin.cpp
<https://git.reviewboard.kde.org/r/122658/#comment52802>

    For this and below, maybe better use "ClangFormat: LLVM Style", ...



formatters/customscript/customscript_plugin.cpp
<https://git.reviewboard.kde.org/r/122658/#comment52801>

    Rename to 'ClangFormat: .clang-format Style'



formatters/customscript/customscript_plugin.cpp
<https://git.reviewboard.kde.org/r/122658/#comment52803>

    Also add a description, which explains how this one works?
    
    See: `-style` from http://clang.llvm.org/docs/ClangFormat.html


- Kevin Funk


On Feb. 21, 2015, 1:54 a.m., Mario Bielert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122658/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2015, 1:54 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> This patch adds ClangFormat as a predefinded style to customscript_plugin formatter
> 
> 
> Diffs
> -----
> 
>   formatters/customscript/customscript_plugin.cpp 8e2e6bb 
> 
> Diff: https://git.reviewboard.kde.org/r/122658/diff/
> 
> 
> Testing
> -------
> 
> Not much testing required, as it's just a few lines adding the command line and a name.
> 
> 
> Thanks,
> 
> Mario Bielert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150226/037d47a6/attachment.html>