Review Request 122388: Custom Build System human readable defines and include search path for KDevelop kf5/master

Salamander Purake salamanderrake at gmail.com
Wed Feb 18 22:52:57 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/
-----------------------------------------------------------

(Updated Feb. 18, 2015, 10:52 p.m.)


Review request for KDevelop.


Changes
-------

updated for master branch based off of commit 4b636b74a72f9404ab339079e1fb2d89c91d2913 with unit test


Summary (updated)
-----------------

Custom Build System human readable defines and include search path for KDevelop kf5/master


Repository: kdevelop


Description
-------

Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.


Diffs (updated)
-----

  languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp df2c425 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.h e92ebc0 
  languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp f9fb7fe 

Diff: https://git.reviewboard.kde.org/r/122388/diff/


Testing
-------

create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.


Thanks,

Salamander Purake

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150218/6d6b8c0a/attachment.html>


More information about the KDevelop-devel mailing list