Review Request 122708: Crash when error in first line in *.py file

Sven Brauch svenbrauch at googlemail.com
Tue Feb 24 16:04:36 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122708/#review76554
-----------------------------------------------------------


Hmm, I cannot reproduce this. I also don't know how it would happen, if the list is empty then the file should have no lines, and no lines cannot have errors ...
But if it fixes a crash for you, go ahead, the extra check doesn't hurt.
All this code really needs to be refactored anyways.

- Sven Brauch


On Feb. 24, 2015, 11:31 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122708/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 11:31 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Steps for reproduce
>  1. Create test file *test.py*:
> ```
> $ echo '!!!' > test.py
> ```
>  2. Open *test.py* in KDevelop 1.7.x
> 
> 
> Diffs
> -----
> 
>   parser/astbuilder.cpp 00f4c5d 
> 
> Diff: https://git.reviewboard.kde.org/r/122708/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150224/d1a89fd5/attachment.html>


More information about the KDevelop-devel mailing list