Review Request 122388: Custom Build System human readable defines and include search path for KDevelop 4.7

[Kevin Funk]

> On Feb. 3, 2015, 10:50 a.m., Milian Wolff wrote:
> > Hey Salamander, there are still some issues here. Also, I just now notice that you want to target KDevelop 4.7. I'd say lets not do it there, but only do it in kf5-based master of kdevelop. Can you fix the issues and forward-port this patch to master? Also, please add a unit test, afaik in master there are even more tests, so you should find some inspiration on how to do this.
> > 
> > I'd especially want to see a unit test to check that the backwards compatibility is not broken.
> 
> Salamander Purake wrote:
>     I want to target 4.7.1 before it gets released because me and another are trying to get Epic to 'bless' this ide on linux for developing c++ projects since they will more then likely 'bless' rhel/centos because that is what most if not all DCC software companies support like all of the AutoDesk catalog of their DCC. And since centos/rhel love to keep their distros way out of date, I or some one else would have to have a custom build of kdevelop otherwise.

FTW: You're too late -- https://www.kdevelop.org/47/kdevelop-471-released 

Don't have time to review the patch in full atm, so I'll let Sergey do that


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review75286
-----------------------------------------------------------


On Feb. 9, 2015, 10:56 p.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2015, 10:56 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp bcdebe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150209/b7f2fb22/attachment.html>