Review Request 122490: Cleanup "Jump to Outputmark" implementation

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122490/#review75654
-----------------------------------------------------------

Ship it!


+1

Looks good to me.

- Aleix Pol Gonzalez


On Feb. 8, 2015, 11:34 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122490/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2015, 11:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This fixes several issues:
> - grepview plugin depending on the standardoutputview plugin
> - standardoutput providing a globally useful shortcut combo
> - F4 / Shift+F4 jumping to two different documents in case there are
>   output marks in both the output view and the grep view result view
> 
> This patch provides a new interface (IToolViewActionListener) which
> can be implemented by plugins providing a tool view,
> which in turn provides a list of output marks one could jump to. The
> actual shortcuts got moved to kdevplatformshell instead.
> 
> The toolview "listening" to those shortcuts is selected on a
> LRU basis -- The last "activated" tool view will receive the shortcut
> events.
> 
> 
> Diffs
> -----
> 
>   interfaces/iuicontroller.h 8e17e0dcf2043b66388ffdec47b1bc72b798d908 
>   plugins/grepview/grepoutputview.h 881dbc0a94a4ff7e8f2e98158a8ad2509b2108a9 
>   plugins/grepview/grepoutputview.cpp 84076d4af25ec64d6b65a1d4cb4b3b94074527c6 
>   plugins/standardoutputview/outputwidget.h 88415cfd4755d24d15c9598a283deca43b63b04c 
>   plugins/standardoutputview/outputwidget.cpp 5babb1977afe929531f6468678b4a78f9a203174 
>   plugins/standardoutputview/standardoutputview.h 772f75ad9d59b57899e40995f344033a65c16212 
>   plugins/standardoutputview/standardoutputview.cpp 414fc8752601f62f258bf38e1a73be28653b009d 
>   shell/mainwindow_actions.cpp ae670df2494a5964cc45e5ebcc807e9b8be60ab8 
>   shell/mainwindow_p.h affb1f624fb705908932839767e1f6127836a464 
>   shell/mainwindow_p.cpp 12723ea5f84f6a422002d165591f594b300348f1 
>   shell/uicontroller.h cc904ece895f836f09bda0bb3a311f9ec44a50a8 
>   shell/uicontroller.cpp 0f2270be2e8a9b41c3e57aec5d6177503533b4fd 
>   interfaces/CMakeLists.txt 22553eaa40cc739241cb97fcb5c2a0f4b01ca426 
>   interfaces/itoolviewactionlistener.h PRE-CREATION 
>   interfaces/itoolviewactionlistener.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122490/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150209/034df96d/attachment.html>