Review Request 121777: Make it possible to change language standard for the parser

[Sergey Kalinichev]

> On Feb. 4, 2015, 1:57 p.m., Milian Wolff wrote:
> > languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp, line 48
> > <https://git.reviewboard.kde.org/r/121777/diff/7/?file=346769#file346769line48>
> >
> >     is this still used somewhere? could that be made the `"Compiler"` group instead?

>is this still used somewhere?

Yes. It used for user-defined compilers.

>could that be made the "Compiler" group instead?

I don't think so. They stored all together.


> On Feb. 4, 2015, 1:57 p.m., Milian Wolff wrote:
> > languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp, line 35
> > <https://git.reviewboard.kde.org/r/121777/diff/7/?file=346772#file346772line35>
> >
> >     what for?

For IndexedString of course
I'm using the project->fileSet() here.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121777/#review75363
-----------------------------------------------------------


On Feb. 4, 2015, 1:23 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121777/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 1:23 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Now we can choose different language standards for computing standard include directories/defined macros. 
> Also this feature is very useful for the kdev-clang plugin (Now it's possible to parse plain C projects).
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.cpp 8d47690 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.h 139b33c 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp 24d711d 
>   languages/plugins/custom-definesandincludes/compilerprovider/icompiler.h 3627ebd 
>   languages/plugins/custom-definesandincludes/compilerprovider/compilerfactories.h 00042fb 
>   languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.h 079b78d 
>   languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp a9feab8 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.cpp 70b9919 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.cpp aebbf5a 
>   languages/plugins/custom-definesandincludes/kcm_widget/compilerswidget.ui 0c90cee 
>   languages/plugins/custom-definesandincludes/kcm_widget/definesandincludesconfigpage.cpp e1d6dda 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.h fe9124c 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathsmodel.cpp 7d4347a 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 446ddb5 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 5b34e75 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 06a6c51 
>   languages/plugins/custom-definesandincludes/compilerprovider/icompiler.cpp 0bf6a44 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/test_compilerprovider.h dbd9a9c 
>   languages/plugins/custom-definesandincludes/compilerprovider/icompilerfactory.h 3849bcb 
>   languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.h a59a6b7 
>   languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.cpp fcd9db7 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.h 5cb3ca0 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp 229f456 
>   languages/plugins/custom-definesandincludes/compilerprovider/tests/CMakeLists.txt 8898c86 
> 
> Diff: https://git.reviewboard.kde.org/r/121777/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150204/69eb89cb/attachment.html>