Review Request 122388: Custom Build System human readable defines and include search path for KDevelop 4.7

[Salamander Purake]

> On Feb. 3, 2015, 9:32 a.m., Sergey Kalinichev wrote:
> > languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp, line 88
> > <https://git.reviewboard.kde.org/r/122388/diff/2/?file=346495#file346495line88>
> >
> >     This is unrelated.

This is not mine.


- Salamander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review75274
-----------------------------------------------------------


On Feb. 2, 2015, 10:11 p.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2015, 10:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp bcdebe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150203/5e2edb3f/attachment-0001.html>