Review Request 122388: Custom Build System human readable defines and include search path for KDevelop 4.7

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122388/#review75274
-----------------------------------------------------------


First of all why? Why do you need it? We already have the GUI for that: project->setting->custom defines and includes. 
If you want to edit includes/defines without opening a project there is a kdev_includepathsconverter tool. If you find that it misses some functionality, feel free to add it there.


languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52062>

    This is unrelated.



languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp
<https://git.reviewboard.kde.org/r/122388/#comment52063>

    That's wrong. Macros can be used without value


Also even if it goes in you have to write unit tests. See also TestCompilerProvider::testStorageBackwardsCompatible

- Sergey Kalinichev


On Feb. 3, 2015, 2:11 a.m., Salamander Purake wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122388/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2015, 2:11 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Made the defines and include path lists human readable by removing the QDataStream and QByte types from the save load steps.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/compilerprovider/settingsmanager.cpp bcdebe5 
> 
> Diff: https://git.reviewboard.kde.org/r/122388/diff/
> 
> 
> Testing
> -------
> 
> create/load a custom build system project (${project-name}.kdev4) add defines and includes path to project via in the text file and the dialog. Tested the defines lines inside the source code files and the autocompletion also in the code files.
> 
> 
> Thanks,
> 
> Salamander Purake
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150203/08edf9f9/attachment-0001.html>