Review Request 122373: Fix crash when folder 'open'ed in project manager view

[Milian Wolff]

> On Feb. 2, 2015, 11:54 a.m., Aleix Pol Gonzalez wrote:
> > I don't think KService should crash...
> > Do you have a bug report or a backtrace?
> 
> Milian Wolff wrote:
>     that, and maybe we should add the check sooner, to prevent showing a "Open" action at all. These error dialogs are pretty bad, usability wise I think.

I've done this locally now and will push it. Thanks for spotting this issue, I guess it can happen in non-kde environments (e.g. when you don't have dolphin installed?). doesn't hurt.


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122373/#review75204
-----------------------------------------------------------


On Feb. 1, 2015, 10:06 p.m., Matthew Suozzo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122373/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2015, 10:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> 'Open' right-click command on folder when there is no compatible document controller results in a segfault crash.
> 
> Fix produces a sorry popup alerting the user to this error.
> 
> 
> Diffs
> -----
> 
>   plugins/openwith/openwithplugin.cpp cd1a7dc 
> 
> Diff: https://git.reviewboard.kde.org/r/122373/diff/
> 
> 
> Testing
> -------
> 
> On Stock Ubuntu (14.04 used):
> 1. Create Project.
> 2. Create folder in project.
> 3. Right Click folder.
> 4. Select 'Open'.
> 
> Before: Resulted in Segfault prior to fix due to a null pointer dereference.
> After Fix: Pops up a dialog alerting the user that there is no compatible file manager.
> 
> 
> Thanks,
> 
> Matthew Suozzo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150202/a8147d4a/attachment.html>