Review Request 122322: custombuildsystem: More useful error messages when a custom tool is not setup

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122322/#review75152
-----------------------------------------------------------



projectmanagers/custom-buildsystem/custombuildjob.cpp
<https://git.reviewboard.kde.org/r/122322/#comment51990>

    or better, use i18nc and give context on both %1 and %2, so that it can be changed in other languages, if needed.



projectmanagers/custom-buildsystem/custombuildjob.cpp
<https://git.reviewboard.kde.org/r/122322/#comment51991>

    setObjectName(title())


- Milian Wolff


On Jan. 29, 2015, 11:28 p.m., Nicolai Hähnle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122322/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2015, 11:28 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> custombuildsystem: More useful error messages when a custom tool is not setup
> 
> 
> Diffs
> -----
> 
>   projectmanagers/custom-buildsystem/CMakeLists.txt 7bb019ed100bfe02d1bfb19218a37adb4719f23c 
>   projectmanagers/custom-buildsystem/custombuildjob.h aad78cd0fd31993143dad60d681182901efedaad 
>   projectmanagers/custom-buildsystem/custombuildjob.cpp 3677fcf3a62a638e357031adb341e834c3197c21 
>   projectmanagers/custom-buildsystem/custombuildsystemconfig.h 0a8c3f163868a9fc039f91f6fd70d6f99ee014ae 
>   projectmanagers/custom-buildsystem/custombuildsystemconfig.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/122322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolai Hähnle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150201/82f32173/attachment.html>