Review Request 122361: Port plugin to JSON

Kevin Funk kfunk at kde.org
Sun Feb 1 14:49:49 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122361/#review75145
-----------------------------------------------------------



kdevqmljs.json
<https://git.reviewboard.kde.org/r/122361/#comment51986>

    Should be a list, too


- Kevin Funk


On Feb. 1, 2015, 12:59 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122361/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2015, 12:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch removes the .desktop file describing kdev-qmljs and replaces it with a .json file that is embedded as part of the plugin.
> 
> 
> Diffs
> -----
> 
>   kdevqmljssupport.desktop.cmake fe57e77 
>   CMakeLists.txt 5f6a377 
>   kdevqmljs.json PRE-CREATION 
>   kdevqmljsplugin.cpp 098124e 
> 
> Diff: https://git.reviewboard.kde.org/r/122361/diff/
> 
> 
> Testing
> -------
> 
> After having installed the plugin, removed its previously installed .desktop file and run kbuildsycoca5, the plugin is still correctly loaded and the testsuite passes. QML and Javascript files are still recognized by the full KDevelop environment.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20150201/3cef63db/attachment.html>


More information about the KDevelop-devel mailing list